fix(anvil): Port Reth's gas estimation and fix wrong executor error#4885
Merged
fix(anvil): Port Reth's gas estimation and fix wrong executor error#4885
Conversation
2 tasks
mattsse
approved these changes
May 5, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We missed a few cases with #4861. To avoid so, we're just porting what was left of Reth's gas estimation method, which handles a few more special cases. As we're using revm 3 things are not exactly 1:1, but they are pretty close.
We also fix a somewhat unrelated executor bug that would throw an incorrect error.
Closes #4877 and #4882.